Fixed an issue where primitive values in payload for InvokeFunctionCommand were not working. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashishdhingra
changed the title
ashishdhingra
force-pushed
the
user/ashdhin/DelmitedStringAndPrimitivePayload-Issue1197
branch
from
1d803c3 to
4f60487
Compare
normj
approved these changes
Nov 1, 2024
philasmar
requested changes
Nov 1, 2024
| @@ -15,7 +15,7 @@ | |||
| <Copyright>Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.</Copyright> | |||
| <Product>AWS Lambda Tools for .NET CLI</Product> | |||
| <TreatWarningsAsErrors>false</TreatWarningsAsErrors> | |||
| <Version>5.11.0</Version> | |||
There was a problem hiding this comment.
you shouldn't be manually updating the version. This will be done part of the release process. Also, please add a change file to the PR https://github.com/aws/aws-extensions-for-dotnet-cli/blob/master/CONTRIBUTING.md#adding-a-change-file-to-your-contribution-branch
…mmand were not working.
ashishdhingra
force-pushed
the
user/ashdhin/DelmitedStringAndPrimitivePayload-Issue1197
branch
from
4f60487 to
56961f1
Compare
philasmar
approved these changes
Nov 1, 2024
normj
approved these changes
Nov 1, 2024
ashishdhingra
deleted the
user/ashdhin/DelmitedStringAndPrimitivePayload-Issue1197
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: aws/aws-lambda-dotnet#1197
Description of changes:
Fixed an issue where primitive valuesin payload for InvokeFunctionCommand were not working.
We copy .NET Extensions CLI tooling code in AWS Visual Studio Toolkit. VS Toolkit is targeting
.NET Frameworkand hence it would not haveSystem.Text.Json. So we have ported logic implemented in VS Toolkit, in .NET Extensions for CLI.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.