Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "End demo meeting faster when video service unavailable (#636)" #638

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

ziyiz-amzn
Copy link
Contributor

This reverts commit 4750a80.

ℹ️ Description

revert the change because the workaround is not needed and a fix has been completed on media backend.

Issue #, if available

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • README update
    • CHANGELOG update
    • guides update
  • This change requires a dependency update
    • Amazon Chime SDK Media
    • Other (update corresponding legal documents)

🧪 How Has This Been Tested?

describe the tests that you ran to verify your changes, any relevant details for your test configuration

Unit test coverage

  • Class coverage:
  • Line coverage:

Additional Manual Test

  • Pause and resume remote video
  • Switch local camera
  • Rotate screen back and forth

📱 Screenshots, if available

provide screenshots/video record if there's a UI change in demo app

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ziyiz-amzn ziyiz-amzn merged commit e70eac3 into development Oct 10, 2024
2 of 4 checks passed
@ziyiz-amzn ziyiz-amzn deleted the revert-demo-change branch October 10, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants