Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build-s3-dist.sh and run-unit-tests.sh to Handle Paths with Spaces #47

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adam-intel
Copy link

Description of changes:
This update enhances the build script to properly handle paths with spaces. The script now correctly handles directory names that contain spaces by wrapping variables in quotes when they are used in commands.

This change does not alter any functional aspects of the script other than improving its compatibility with directory names containing spaces.

Testing:
The script was tested in environments with and without spaces in directory paths to ensure that it functions correctly in both scenarios.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Allow build-s3-dist.sh to work when the current working directory has spaces.
@mikeols mikeols added the enhancement New feature or request label Dec 19, 2023
@mikeols
Copy link
Member

mikeols commented Dec 19, 2023

Thanks @adam-intel. These changes seem reasonable, but we will review. We cannot merge these PRs directly, but if this change is accepted, we can incorporate it into a future release.

Apply the same fix for the run-unit-tests.sh
@adam-intel adam-intel changed the title Update build-s3-dist.sh to Handle Paths with Spaces Update build-s3-dist.sh and run-unit-tests.sh to Handle Paths with Spaces Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants