This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
Added instructions to install AWS-SDK for Counter. #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @monilbid, Like I said in the linked issue, this isn't necessary to deploy and without further instructions on how to test the Lambda locally this doesn't end up being useful. We can discuss in the linked issue why you think this instruction should be added 🙂 And we can come back to this PR if there ends up being something we can do to improve any confusion you may have had |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730
This PR adds a line to the instructions in the Hit Counter phase of the TypeScript instructions that tells the user that they need to install the AWS SDK because it hasn't previously been mentioned to the user.
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT-0 License.