pin webpack dependency versions so they won't break, and we can update them manually when we need to #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, this PR is superceded by
which includes these changes. That PR removes build tooling, allowing the front end code to simply work forever without build tools breaking. This is advantageous because people here do not have the resources and time to fiddle with build tools.
Let end users configure build tools for their apps as they wish, while this repo focuses on the Sumerian functionality and the simplicity of maintaining it.
Description
We presumably had an in-range breaking change with a webpack dependency. I solved the issue by simply pinning webpack lib versions. I also update package-lock.json to ensure there's a way to reproduce a good build (f.e. with
npm ci
instead ofnpm install
).Related Issue #
This issue was noticed in
but actually is not related to that change, and happens on
mainline2.0
.Reviewer Testing Instructions
Run
npm install && npm start
and it should work.Submission Checklist
I confirm that I have...
Additional (not part of the pull request template):
This contribution is licensed under the original MIT-0 license of the repository. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.