Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin webpack dependency versions so they won't break, and we can update them manually when we need to #181

Conversation

trusktr
Copy link

@trusktr trusktr commented Aug 27, 2023

Note, this PR is superceded by

which includes these changes. That PR removes build tooling, allowing the front end code to simply work forever without build tools breaking. This is advantageous because people here do not have the resources and time to fiddle with build tools.

Let end users configure build tools for their apps as they wish, while this repo focuses on the Sumerian functionality and the simplicity of maintaining it.

Description

We presumably had an in-range breaking change with a webpack dependency. I solved the issue by simply pinning webpack lib versions. I also update package-lock.json to ensure there's a way to reproduce a good build (f.e. with npm ci instead of npm install).

Related Issue #

This issue was noticed in

but actually is not related to that change, and happens on mainline2.0.

Reviewer Testing Instructions

Run npm install && npm start and it should work.

Submission Checklist

I confirm that I have...

  • removed hard-coded Cognito IDs
  • manually smoke-tested the BabylonJS integration tests
  • manually smoke-tested the BabylonJS demos
  • manually smoke-tested the Three.js integration tests
  • manually smoke-tested the Three.js demo

Additional (not part of the pull request template):

  • manually smoke-tested the core integration test, but it is broken (including in mainline2.0), although not a big deal if both Babylon and Three.js demos work.

This contribution is licensed under the original MIT-0 license of the repository. By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trusktr
Copy link
Author

trusktr commented Feb 16, 2024

Note, this PR is superceded by

which removes build tooling, allowing the front end code to simply work forever without build tools breaking. This is advantageous because people here do not have the resources and time to fiddle with build tools. Let end users configure build tools for their apps as they wish, while this repo focuses on the Sumerian functionality!

@trusktr trusktr closed this Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant