Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(logger): allow custom JMESPath functions to extract correlation ID #3382

Merged
merged 6 commits into from
Nov 21, 2023

Conversation

heitorlessa
Copy link
Contributor

Issue number: #3381

Summary

This 3-year bug prevented customers from using custom JMESPath Functions like powertools_json to deserialize and extract correlation ID more easily.

Changes

Please provide a summary of what's being changed

  • Use jmespath_utils instead of jmespath.search
  • Briefly mention that custom jmespath functions work in Docs
  • Add missing test

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@heitorlessa heitorlessa requested a review from a team as a code owner November 21, 2023 14:49
@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation logger tests labels Nov 21, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 21, 2023
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

@heitorlessa heitorlessa merged commit 8e0ab8c into aws-powertools:develop Nov 21, 2023
15 checks passed
@heitorlessa heitorlessa deleted the fix/logger-jmespath branch November 21, 2023 15:00
@heitorlessa heitorlessa added the bug Something isn't working label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation logger size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants