Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(general): add support for Python 3.12 #3304

Merged
merged 19 commits into from
Dec 14, 2023

Conversation

leandrodamascena
Copy link
Contributor

@leandrodamascena leandrodamascena commented Nov 7, 2023

Issue number: #3272

Summary

Changes

Python 3.12 official docker image is available in preview: aws/aws-lambda-base-images#110 (comment). We can start preparing to add support Python 3.12 in Powertools for AWS Lambda.

Required Steps

  • Validate all features supported by Powertools using AWS Lambda Python3.12 image
  • Validate Pydantic and Pydanticv2 using AWS Lambda Python3.12 image
  • Update all docs examples to use python3.12 instead of python3.11
  • Run e2e test
  • Wait the new Runtime be supported by CDK
  • Wait the new Runtime be supported by SAM
  • CDK Layer repository - Bump the CDK version to support the new AWS Lambda Python runtime version
  • CDK Layer repository - Change the supported runtimes to include the new runtime
  • CDK Layer repository - Make sure tests still pass by running yarn projen test
  • CDK Layer repository - Submit and merge a PR with the changes
  • CDK Layer repository - Execute the release workflow to generate a new version of the construct from the main branch
  • Layer - Bump the CDK version on the on the root of the repository, by editing package.json and running npm install
  • Layer - Inside the layer directory: bump the Layer construct version by editing the pyproject.toml and running poetry lock.
  • Add the new runtime to the layer/sar/template.txt

Launch day

  • Wait for the official announcement of Lambda Python 3.12 to merge this PR.

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner November 7, 2023 18:19
@boring-cyborg boring-cyborg bot added dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code github-templates tests labels Nov 7, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16db46d) 95.43% compared to head (a4d34f7) 95.78%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3304      +/-   ##
===========================================
+ Coverage    95.43%   95.78%   +0.35%     
===========================================
  Files          209      209              
  Lines         9675     9675              
  Branches      1774     1774              
===========================================
+ Hits          9233     9267      +34     
+ Misses         329      294      -35     
- Partials       113      114       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena linked an issue Nov 7, 2023 that may be closed by this pull request
2 tasks
@heitorlessa heitorlessa added this to the Python 3.12 milestone Nov 13, 2023
rubenfonseca
rubenfonseca previously approved these changes Nov 15, 2023
Copy link
Contributor

@rubenfonseca rubenfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

@leandrodamascena leandrodamascena marked this pull request as draft November 16, 2023 09:57
@leandrodamascena leandrodamascena marked this pull request as ready for review December 6, 2023 21:02
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rubenfonseca rubenfonseca merged commit 228b715 into aws-powertools:develop Dec 14, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation github-actions Pull requests that update Github_actions code github-templates size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Support for Python 3.12
4 participants