-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(event_handler): add ability to expose a Swagger UI #3254
Conversation
143a6ff
to
01e3ddd
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3254 +/- ##
===========================================
+ Coverage 95.14% 95.24% +0.09%
===========================================
Files 205 207 +2
Lines 9517 9581 +64
Branches 1742 798 -944
===========================================
+ Hits 9055 9125 +70
+ Misses 342 338 -4
+ Partials 120 118 -2
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@leandrodamascena addressed your comments, answered the pending questions and re-requested a review |
Quick one for now: Add the constraint to the linked issue that this is not yet for customers using micro-functions. This is only useful for customers with a single Lambda with many routes. |
I'm currently managing a combination of a hodge podge of solutions to achieve this functionality and this feature would be greatly appreciated by my team :) @leandrodamascena respectfully, are there any remaining issues here? |
Hi @guywilsonjr! It's amazing to know that this feature will make your life easier when working with OpenAPI Spec + Swagger. There are no critical issues here and we hope to merge this PR early next week and release it soon. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APPROVED @rubenfonseca! 🚀 |
Issue number: #3253
Summary
Changes
This PR adds the ability to expose a Swagger UI from the AWS Lambda. It works with all supported REST gateways.
In addition:
include_in_schema
)User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.