Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(data_masking): move Data Masking utility to a private folder #3202

Merged

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #3201

Summary

Changes

This pull request involves refactoring the Data Masking utility by moving it to a private folder. This change is part of our ongoing efforts to create the documentation and improve some parts of the code.

User experience

There is a change in the user experience.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team as a code owner October 13, 2023 10:34
@boring-cyborg boring-cyborg bot added the tests label Oct 13, 2023
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5997da5) 95.96% compared to head (f308bd9) 95.96%.
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3202   +/-   ##
========================================
  Coverage    95.96%   95.96%           
========================================
  Files          195      195           
  Lines         8387     8387           
  Branches      1563     1563           
========================================
  Hits          8049     8049           
  Misses         276      276           
  Partials        62       62           
Files Coverage Δ
...bda_powertools/utilities/_data_masking/__init__.py 100.00% <100.00%> (ø)
..._lambda_powertools/utilities/_data_masking/base.py 94.44% <100.00%> (ø)
...da_powertools/utilities/_data_masking/constants.py 100.00% <ø> (ø)
...tools/utilities/_data_masking/provider/__init__.py 100.00% <100.00%> (ø)
...owertools/utilities/_data_masking/provider/base.py 100.00% <100.00%> (ø)
...s/utilities/_data_masking/provider/kms/__init__.py 100.00% <100.00%> (ø)
...s/_data_masking/provider/kms/aws_encryption_sdk.py 48.88% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena changed the title refactor(data_masking): moving Data Masking utility to a private folder refactor(data_masking): move Data Masking utility to a private folder Oct 13, 2023
@leandrodamascena leandrodamascena added the data-masking Sensitive Data Masking feature label Oct 13, 2023
@rubenfonseca
Copy link
Contributor

Looking at this now

@leandrodamascena leandrodamascena merged commit 5bfb60f into aws-powertools:develop Oct 13, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-masking Sensitive Data Masking feature size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants