-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(idempotency): add support to custom serialization/deserialization on idempotency decorator #2951
feat(idempotency): add support to custom serialization/deserialization on idempotency decorator #2951
Conversation
…ss, in order to allow refactoring later on in regards to string seriliztion
…aron/powertools-lambda-python into feat/idempotency-output-serializer
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
No related issues found. Please ensure there is an open issue related to this change to avoid significant delays or closure. |
Hi @aradyaron! Thanks so much for sending this PR, it's absolutely awesome to add this support in the Idempotency utility without breaking changes. We will start reviewing this PR by tomorrow and hope to merge it as soon as possible. 🚀 |
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2951 +/- ##
===========================================
- Coverage 96.56% 96.51% -0.06%
===========================================
Files 175 180 +5
Lines 7825 7909 +84
Branches 1476 1491 +15
===========================================
+ Hits 7556 7633 +77
- Misses 217 221 +4
- Partials 52 55 +3
☔ View full report in Codecov by Sentry. |
Looking at this now |
fix edge case where dict is {} and not None
I'm working with @sthulb to review the documentation and merge this PR. 🚀 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
This is now released under 2.24.0 version! |
Issue number: #2886
Summary
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.