Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layer): publish SAR v2 via Github actions #1585

Merged
merged 45 commits into from
Oct 13, 2022
Merged

feat(layer): publish SAR v2 via Github actions #1585

merged 45 commits into from
Oct 13, 2022

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Oct 11, 2022

Issue number: #1543

Summary

This PR adds support for creating the v2 SAR via Github Actions.

Changes

Please provide a summary of what's being changed

  • Rename V2 Layer and Canary stacks to LayerV2Stack and CanaryV2Stack, to avoid clashing with the existing v1 stack which we will want to maintain
  • Re-use the Lambda Layer artifact to publish the SAR using SAM
  • No more dependencies with internal pipelines
  • Authentication using OIDC as a jump role

User experience

Please share what the user experience looks like before and after this change

A successful SAR release will now look like this (please ignore the Layer deployment failure):

image

Checklist

  • After merge, remove feat/sar-v2 from environment branches

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added the github-actions Pull requests that update Github_actions code label Oct 11, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 11, 2022
@rubenfonseca rubenfonseca linked an issue Oct 11, 2022 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the feature New feature or functionality label Oct 11, 2022
@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label Oct 11, 2022
@rubenfonseca rubenfonseca marked this pull request as ready for review October 13, 2022 09:50
@rubenfonseca rubenfonseca requested a review from a team as a code owner October 13, 2022 09:50
@rubenfonseca rubenfonseca requested review from leandrodamascena, heitorlessa and a team and removed request for a team and leandrodamascena October 13, 2022 09:50
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! It gives me a great relief to have the entire release now centralized.

Changes:

  • GH is deprecating set-output (no ETA yet) - suggested the superseding mechanism
  • Note to create a Maintenance issue to convert the longest inline parts into a script (after V2 is launched, not now)
  • Pieces where a comment could be helpful for our future selves

.github/workflows/publish_v2_layer.yml Outdated Show resolved Hide resolved
.github/workflows/publish_v2_layer.yml Outdated Show resolved Hide resolved
.github/workflows/reusable_deploy_v2_sar.yml Outdated Show resolved Hide resolved
.github/workflows/reusable_deploy_v2_sar.yml Outdated Show resolved Hide resolved
.github/workflows/reusable_deploy_v2_sar.yml Show resolved Hide resolved
.github/workflows/reusable_deploy_v2_sar.yml Outdated Show resolved Hide resolved
.github/workflows/reusable_deploy_v2_sar.yml Show resolved Hide resolved
.github/workflows/reusable_deploy_v2_sar.yml Outdated Show resolved Hide resolved
.github/workflows/reusable_deploy_v2_sar.yml Outdated Show resolved Hide resolved
.github/workflows/reusable_deploy_v2_sar.yml Show resolved Hide resolved
@rubenfonseca
Copy link
Contributor Author

Screenshot updated

use active voice to shorten the length
remove fragmented sentence by combining them.
@rubenfonseca rubenfonseca merged commit be64e4e into v2 Oct 13, 2022
@rubenfonseca rubenfonseca deleted the feat/sar-v2 branch October 13, 2022 13:38
rubenfonseca added a commit that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file feature New feature or functionality github-actions Pull requests that update Github_actions code size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: Deprecate SAR extras for v2
2 participants