-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(layer): publish SAR v2 via Github actions #1585
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
github-actions
Pull requests that update Github_actions code
label
Oct 11, 2022
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Oct 11, 2022
2 tasks
boring-cyborg
bot
added
the
dependencies
Pull requests that update a dependency file
label
Oct 11, 2022
rubenfonseca
force-pushed
the
feat/sar-v2
branch
from
October 13, 2022 09:50
178c627
to
b98d539
Compare
rubenfonseca
requested review from
leandrodamascena,
heitorlessa and
a team
and removed request for
a team and
leandrodamascena
October 13, 2022 09:50
heitorlessa
reviewed
Oct 13, 2022
heitorlessa
reviewed
Oct 13, 2022
heitorlessa
suggested changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! It gives me a great relief to have the entire release now centralized.
Changes:
- GH is deprecating
set-output
(no ETA yet) - suggested the superseding mechanism - Note to create a Maintenance issue to convert the longest inline parts into a script (after V2 is launched, not now)
- Pieces where a comment could be helpful for our future selves
Co-authored-by: Heitor Lessa <[email protected]>
Screenshot updated |
heitorlessa
reviewed
Oct 13, 2022
heitorlessa
reviewed
Oct 13, 2022
use active voice to shorten the length
heitorlessa
reviewed
Oct 13, 2022
remove fragmented sentence by combining them.
heitorlessa
reviewed
Oct 13, 2022
heitorlessa
approved these changes
Oct 13, 2022
rubenfonseca
added a commit
that referenced
this pull request
Oct 14, 2022
Co-authored-by: Heitor Lessa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
feature
New feature or functionality
github-actions
Pull requests that update Github_actions code
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #1543
Summary
This PR adds support for creating the v2 SAR via Github Actions.
Changes
User experience
A successful SAR release will now look like this (please ignore the Layer deployment failure):
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.