-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Extract inline script from SAR GH action #1592
Comments
Hey @sthulb! This issue is related to GH actions cross-repo clean up. |
@rubenfonseca started moving inline scripts into their own script file to clean up our actions, make them more readable, maintainable and even reuse the script in other actions. |
I'm going to close this as not a requirement – this seems like the main body (https://github.com/aws-powertools/powertools-lambda-python/blob/develop/.github/workflows/reusable_deploy_v2_sar.yml#L166-L201) is just a bunch of AWS CLI commands, there's not much point in extracting it |
|
Summary
We should extract the inline scripts from the
reusable_deploy_v2_sar
GH action workflow into scripts into ascripts/
folder.Why is this needed?
To prevent error-prone updates and make it easier to test.
Which area does this relate to?
Automation
Solution
No response
Acknowledgment
The text was updated successfully, but these errors were encountered: