Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Extract inline script from SAR GH action #1592

Closed
1 of 2 tasks
rubenfonseca opened this issue Oct 13, 2022 · 4 comments
Closed
1 of 2 tasks

Maintenance: Extract inline script from SAR GH action #1592

rubenfonseca opened this issue Oct 13, 2022 · 4 comments
Assignees
Labels
internal Maintenance changes

Comments

@rubenfonseca
Copy link
Contributor

Summary

We should extract the inline scripts from the reusable_deploy_v2_sar GH action workflow into scripts into a scripts/ folder.

Why is this needed?

To prevent error-prone updates and make it easier to test.

Which area does this relate to?

Automation

Solution

No response

Acknowledgment

@rubenfonseca rubenfonseca added triage Pending triage from maintainers internal Maintenance changes labels Oct 13, 2022
@heitorlessa heitorlessa removed the triage Pending triage from maintainers label Mar 24, 2023
@sthulb sthulb moved this from Triage to On hold in Powertools for AWS Lambda (Python) Jun 19, 2023
@leandrodamascena leandrodamascena moved this from On hold to Backlog in Powertools for AWS Lambda (Python) Sep 1, 2023
@leandrodamascena
Copy link
Contributor

Hey @sthulb! This issue is related to GH actions cross-repo clean up.

@leandrodamascena
Copy link
Contributor

Is there a practical reason to move this to it's own script file?

@rubenfonseca started moving inline scripts into their own script file to clean up our actions, make them more readable, maintainable and even reuse the script in other actions.

@sthulb
Copy link
Contributor

sthulb commented Sep 7, 2023

I'm going to close this as not a requirement – this seems like the main body (https://github.com/aws-powertools/powertools-lambda-python/blob/develop/.github/workflows/reusable_deploy_v2_sar.yml#L166-L201) is just a bunch of AWS CLI commands, there's not much point in extracting it

@sthulb sthulb closed this as completed Sep 7, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Coming soon in Powertools for AWS Lambda (Python) Sep 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

This issue is now closed. Please be mindful that future comments are hard for our team to see.

If you need more assistance, please either tag a team member or open a new issue that references this one.

If you wish to keep having a conversation with other community members under this issue feel free to do so.

@leandrodamascena leandrodamascena moved this from Coming soon to Shipped in Powertools for AWS Lambda (Python) Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal Maintenance changes
Projects
Status: Shipped
Development

No branches or pull requests

4 participants