Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Sync main with develop for release to fix metrics output #665

Merged
merged 4 commits into from
Oct 9, 2024
Merged

chore: Sync main with develop for release to fix metrics output #665

merged 4 commits into from
Oct 9, 2024

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Oct 9, 2024 •
edited
Loading

Please provide the issue number

Issue number: #662

Summary

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@auto-assign auto-assign bot requested review from amirkaws and sliedig October 9, 2024 08:48
@boring-cyborg boring-cyborg bot added area/metrics Core metrics utility tests labels Oct 9, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 9, 2024
@github-actions github-actions bot added the internal Maintenance changes label Oct 9, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@hjgraca hjgraca merged commit 133e4f3 into main Oct 9, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amirkaws amirkaws Awaiting requested review from amirkaws

@sliedig sliedig Awaiting requested review from sliedig

Assignees
No one assigned
Labels
area/metrics Core metrics utility internal Maintenance changes size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjgraca @rubenfonseca