-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EC2 default test with new sample apps deployment #348
base: main
Are you sure you want to change the base?
EC2 default test with new sample apps deployment #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a more recent test run to prove it works, try recreating your branch on the main repo and running the test by calling the workflow on your branch.
if [[ "${var.language_version}" == "8.0" ]]; then | ||
sudo dnf install -y dotnet-sdk-8.0 | ||
else | ||
sudo dnf install -y dotnet-sdk-6.0 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should use 8.0 as default
if [[ "${var.language_version}" == "8.0" ]]; then | |
sudo dnf install -y dotnet-sdk-8.0 | |
else | |
sudo dnf install -y dotnet-sdk-6.0 | |
fi | |
if [[ "${var.language_version}" == "6.0" ]]; then | |
sudo dnf install -y dotnet-sdk-6.0 | |
else | |
sudo dnf install -y dotnet-sdk-8.0 | |
fi |
if [[ "${var.language_version}" == "8.0" ]]; then | ||
sudo dnf install -y dotnet-sdk-8.0 | ||
else | ||
sudo dnf install -y dotnet-sdk-6.0 | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Same here
Issue description:
Description of changes: I have made several changes to accommodate the dynamic version handling for dotnet support. This will check the e2e EC2 test for both versions for all regions. I am attaching a link that reflects the same changes on my repository and with the region us-east-1. Here is the link: https://github.com/Jeel-mehta/aws-application-signals-test-framework/actions/runs/12420969815
Rollback procedure:
<Can we safely revert this commit if needed? If not, detail what must be done to safely revert and why it is needed.>
Ensure you've run the following tests on your changes and include the link below:
To do so, create a
test.yml
file withname: Test
and workflow description to test your changes, then remove the file for your PR. Link your test run in your PR description. This process is a short term solution while we work on creating a staging environment for testing.NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL. See the needs keyword to run tests in succession.
e2e-playground
in us-east-1 and eu-central-2e2e-playground
in us-east-1 and eu-central-2e2e-playground
in us-east-1 and eu-central-2By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.