test(uat): log rotation with minimum log level setting #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
==========================================
+ Coverage 84.79% 85.24% +0.45%
==========================================
Files 13 13
Lines 1052 1057 +5
Branches 109 110 +1
==========================================
+ Hits 892 901 +9
+ Misses 100 97 -3
+ Partials 60 59 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Unit Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against e6cb9fa |
|
Integration Tests Coverage Report
Minimum allowed coverage is Generated by 🐒 cobertura-action against e6cb9fa |
MikeDombo
force-pushed
the
uat-1
branch
5 times, most recently
from
d31eeb9 to
d7b14d6
Compare
| List<LogFile> deletableFiles = group.getProcessedLogFiles(); | ||
| deletableFiles.addAll(group.getLogFiles()); |
There was a problem hiding this comment.
lazy question, group.getLogFiles distinct from group.getProcessedLogFiles? seems like we dont want duplicates in delteableFiles
There was a problem hiding this comment.
yes, they're distinct. Even if we duplicate it won't matter as deletion is safe if the file is deleted already.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Why is this change necessary:
How was this change tested:
Any additional information or context required to review the change:
Checklist:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.