Updated withAPIKey to be synchronous #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Galvan <[email protected]>
tjmichaels
approved these changes
Nov 5, 2024
mbalfour-amzn
approved these changes
Nov 5, 2024
mojodna
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed async requirement from
withAPIKey, since there is no asynchronous action being done in the method. We do need to keepwithIdentityPoolIdas async because fetching the credentials is an async operation.Previous logic using
await withAPIKeywill still function as-is sinceawaiton a non-async function will return aPromisethat resolves immediately.Testing
Updated unit tests to test
withAPIKeyusage in both async and sync calls.