Added support for cognito standalone maps URLs #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Galvan <[email protected]>
tjmichaels
previously approved these changes
Nov 5, 2024
mojodna
requested changes
Nov 5, 2024
mojodna
previously approved these changes
Nov 5, 2024
mbalfour-amzn
previously approved these changes
Nov 5, 2024
Signed-off-by: Chris Galvan <[email protected]>
cgalvan
dismissed stale reviews from mbalfour-amzn, mojodna, and tjmichaels
via
c348cfd
mbalfour-amzn
approved these changes
Nov 5, 2024
mojodna
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using an Amazon Cognito Identity Pool ID for authentication with the standalone Maps SDK URL, the signing service name is
geo-maps, instead of justgeo. Updated the logic to handle this, and also restricted the signing for standalone Maps SDK URLs to only be done when fetching the tiles.Testing
Updated the unit tests to handle both standalone Maps SDK URLs and consolidated Location SDK URLs. Added checks to verify the signing is working on all the appropriate resources (descriptor, sprites, glyphs, tiles) for the consolidated Location SDK case, and only signing tiles when using a standalone Maps SDK Url. Also added check to verify the credential is using the correct signing service name.
Also tested with local examples to verify it works for both cases.