Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Flutter): Added required flags to sandbox command when using Flutter #7660

Merged
merged 3 commits into from
May 28, 2024

Conversation

naedx
Copy link
Contributor

@naedx naedx commented May 25, 2024

Description of changes:

  1. Updated the documentation to add the required flag --outputs-version 0 by default to the command snippet for the Flutter docs.
  2. Updated the documentaion to include the explanation in closer proximity to the command.
  3. Correct a typo in the command which from --config-format dart to --outputs-format dart

Preview of changes:

npx ampx sandbox --outputs-format dart --outputs-out-dir lib --outputs-version 0

Related GitHub issue #, if available: aws-amplify/amplify-flutter#4920

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@josefaidt josefaidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @naedx 👋 thanks for taking the time to file this!

Copy link
Contributor

@josefaidt josefaidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested a few filters

Updated the platform filters.

Co-authored-by: josef <[email protected]>
@naedx naedx requested a review from josefaidt May 25, 2024 02:01
@naedx
Copy link
Contributor Author

naedx commented May 25, 2024

Hey @josefaidt ! Good looking out! I've applied the suggestions.

@josefaidt josefaidt merged commit 3e382bd into aws-amplify:main May 28, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants