chore(auth): add authenticated client side validation #12033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthenticated-validation
israx
force-pushed
the
sign-in-authenticated-validation
branch
from
aff0a0a to
b3be14e
Compare
elorzafe
previously approved these changes
Sep 14, 2023
jimblanc
reviewed
Sep 14, 2023
| @@ -630,3 +633,19 @@ export function isMFATypeEnabled( | |||
| if (!mfaTypes) return false; | |||
| return mfaTypes.includes(mfaType); | |||
| } | |||
|
|
|||
| export async function isUserAuthenticated() { | |||
There was a problem hiding this comment.
Nit pick but the current name makes it sound like this behaves like a predicate (i.e. returns a bool to know if user is signed in).
Suggested change
| export async function isUserAuthenticated() { | |
| export async function assertUserNotAuthenticated() { |
There was a problem hiding this comment.
Yeah agree. Sounds more like a predicate. I changed it already. Thanks
…uthenticated-validation
israx
force-pushed
the
sign-in-authenticated-validation
branch
from
fe68ddf to
e33e7c7
Compare
jimblanc
approved these changes
Sep 15, 2023
stocaaro
approved these changes
Sep 15, 2023
| let authUser: AuthUser | undefined; | ||
| try { | ||
| authUser = await getCurrentUser(); | ||
| } catch (error) {} |
There was a problem hiding this comment.
Should we do something with this catch? Maybe log?
There was a problem hiding this comment.
good point. If getCurrentUser throws it's because no tokens were found. So in the context of sign-in that is expected always. So logging something doesn't really help here.
|
To bad as this change made no longer possible to revalidate user password :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR adds client side validation for authenticated users that try to sign-in again.
Other changes:
Improve error messaging for users that call APIs that require the user to be authenticated.
Issue #, if available
Description of how you validated changes
tested change in a sample app, where I was able to get an error when trying to call sign-in while authenticated.
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.