chore(auth): general clean up for credentialsProvider and also rename Credentials from sdk #12021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elorzafe
reviewed
Sep 13, 2023
| export type { | ||
| AwsCredentialIdentity as Credentials, | ||
| MetadataBearer, | ||
| } from '@aws-sdk/types'; |
There was a problem hiding this comment.
are we doing the thing that Allan did on v5 to generate those and have @aws-sdk/types as dev dependency
There was a problem hiding this comment.
Okay, we can create a follow up PR for this. Thanks
elorzafe
approved these changes
Sep 13, 2023
israx
approved these changes
Sep 13, 2023
| export type { | ||
| AwsCredentialIdentity as Credentials, | ||
| MetadataBearer, | ||
| } from '@aws-sdk/types'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
Description of how you validated changes
Works as expected for the following scenarios on a React app,
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.