Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable caching for cognito APIs #12020

Merged
merged 12 commits into from
Sep 14, 2023

Conversation

AllanZhengYP
Copy link
Member

@AllanZhengYP AllanZhengYP commented Sep 12, 2023

Description of changes

Expose cache option from the service API handler as 2nd parameter and set to no-cache for Cognito API calls.

Description of how you validated changes

  • unit tests
  • manually validated with Next.js SSR page(getInitialProps) and API Route
    *Screenshot 2023-09-12 at 6 34 49 PM

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review September 13, 2023 01:41
@AllanZhengYP AllanZhengYP requested review from a team as code owners September 13, 2023 01:41
@AllanZhengYP AllanZhengYP requested a review from HuiSF September 13, 2023 01:44
jimblanc
jimblanc previously approved these changes Sep 13, 2023
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/core/__tests__/clients/fetch.test.ts Outdated Show resolved Hide resolved
jimblanc
jimblanc previously approved these changes Sep 13, 2023
@AllanZhengYP AllanZhengYP merged commit 6ba700b into aws-amplify:next/release Sep 14, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants