test: verify public interfaces are compliant to TS4.0 #12013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
AllanZhengYP
commented
Sep 18, 2023
| @@ -64,7 +64,7 @@ | |||
| "s3" | |||
| ], | |||
| "dependencies": { | |||
| "@smithy/md5-js": "2.0.5", | |||
| "@smithy/md5-js": "2.0.7", | |||
There was a problem hiding this comment.
Required to pull in the latest @smithy/types fix
AllanZhengYP
commented
Sep 18, 2023
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import * as Amplify from 'aws-amplify'; |
There was a problem hiding this comment.
/adapter-nextjs subpath is not included because Next.js usually has more up-to-date TSC support. But it can be included too.
jimblanc
previously approved these changes
Sep 19, 2023
stocaaro
previously approved these changes
Sep 19, 2023
israx
previously approved these changes
Sep 19, 2023
jimblanc
previously approved these changes
Sep 19, 2023
stocaaro
previously approved these changes
Sep 19, 2023
stocaaro
approved these changes
Sep 19, 2023
jimblanc
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Create a test
test:tsc-complianceto verify all public interfaces are complient to TS 4.0This test is currently failing until following changes are made:
Incorrect types in @smithy/types(PR: fix: broken ChecksumConfiguration and ConditionalRecursiveTransformExact interface in TS < 4.4 smithy-lang/smithy-typescript#926)Incorrect generic in Storage(WIP)Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.