Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(adapter-nextjs): improve the inline doc #12009

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 11, 2023

Description of changes

Add detailed inline doc for runWithAmplifyServerContext of the adapter-nextjs package.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner September 11, 2023 23:33
jimblanc
jimblanc previously approved these changes Sep 12, 2023
stocaaro
stocaaro previously approved these changes Sep 12, 2023
@HuiSF HuiSF dismissed stale reviews from stocaaro and jimblanc via 109b9f2 September 12, 2023 16:24
@HuiSF HuiSF force-pushed the hui/chore/adapter-nextjs/improve-inline-doc branch from 7f29de5 to 109b9f2 Compare September 12, 2023 16:24
@HuiSF HuiSF force-pushed the hui/chore/adapter-nextjs/improve-inline-doc branch 2 times, most recently from c5e0522 to 6b49be8 Compare September 13, 2023 18:28
@HuiSF HuiSF force-pushed the hui/chore/adapter-nextjs/improve-inline-doc branch from 6b49be8 to f7dc73d Compare September 13, 2023 19:24
@HuiSF HuiSF force-pushed the hui/chore/adapter-nextjs/improve-inline-doc branch from f7dc73d to a3d3471 Compare September 14, 2023 01:07
@HuiSF HuiSF merged commit a3941f2 into next/release Sep 14, 2023
14 checks passed
@HuiSF HuiSF deleted the hui/chore/adapter-nextjs/improve-inline-doc branch September 14, 2023 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants