(chore)storage: add accessLevel unit tests to getProperties, getUrl apis #11962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
reviewed
Sep 1, 2023
ashwinkumar6
reviewed
Sep 1, 2023
packages/storage/__tests__/providers/s3/apis/getProperties.test.ts
Outdated
Show resolved
Hide resolved
ashwinkumar6
reviewed
Sep 1, 2023
packages/storage/__tests__/providers/s3/apis/getProperties.test.ts
Outdated
Show resolved
Hide resolved
AllanZhengYP
reviewed
Sep 2, 2023
packages/storage/__tests__/providers/s3/apis/getProperties.test.ts
Outdated
Show resolved
Hide resolved
stocaaro
previously approved these changes
Sep 5, 2023
AllanZhengYP
previously approved these changes
Sep 5, 2023
kvramyasri7
dismissed stale reviews from stocaaro and AllanZhengYP
via
b4b8248
AllanZhengYP
reviewed
Sep 5, 2023
packages/storage/__tests__/providers/s3/apis/getProperties.test.ts
Outdated
Show resolved
Hide resolved
stocaaro
previously approved these changes
Sep 5, 2023
AllanZhengYP
reviewed
Sep 5, 2023
packages/storage/__tests__/providers/s3/apis/getProperties.test.ts
Outdated
Show resolved
Hide resolved
packages/storage/__tests__/providers/s3/apis/getProperties.test.ts
Outdated
Show resolved
Hide resolved
AllanZhengYP
reviewed
Sep 5, 2023
stocaaro
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Covered all accessLevel unit test cases related to
getPropertiesandgetUrlapi.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.