fix(core): add @types/node-fetch to runtime dependency #11560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The isomorphic-unfetch dependency re-exports artifacts from node-fetch package in its .d.ts file. However, the node-fetch package does not contain any .d.ts file with itself. So the exported artifacts can not be resolved by tsc. It's not an issue before possibly because the client-s3 contains transitive runtime dependency of @types/node-fetch. Since it's removed now, we are encountered with this error. Adding the dependency to runtime instead of dev or peer deps to prevent brokage for customers
HuiSF
approved these changes
Jun 29, 2023
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## v5/custom-clients #11560 +/- ##
==================================================
Coverage 83.65% 83.65%
==================================================
Files 336 336
Lines 21491 21491
Branches 4586 4586
==================================================
Hits 17978 17978
Misses 3226 3226
Partials 287 287 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jimblanc
approved these changes
Jun 29, 2023
kvramyasri7
pushed a commit
to kvramyasri7/amplify-js
that referenced
this pull request
Jul 7, 2023
…1560) The isomorphic-unfetch dependency re-exports artifacts from node-fetch package in its .d.ts file. However, the node-fetch package does not contain any .d.ts file with itself. So the exported artifacts can not be resolved by tsc. It's not an issue before possibly because the client-s3 contains transitive runtime dependency of @types/node-fetch. Since it's removed now, we are encountered with this error. Adding the dependency to runtime instead of dev or peer deps to prevent brokage for customers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The isomorphic-unfetch dependency re-exports artifacts from node-fetch package in its .d.ts file. However, the node-fetch package does not contain any .d.ts file with itself. So the exported artifacts can not be resolved by tsc. It's not an issue before possibly because the client-s3 contains transitive runtime dependency of @types/node-fetch. Since it's removed now, we are encountered with this error.
Adding the dependency to runtime instead of dev or peer deps to prevent brokage for customers
Issue #, if available
https://github.com/aws-amplify/amplify-ui/actions/runs/5407197729/jobs/9824935017?pr=4182
Typescript issue: weird dependency on node-fetch in declaration file developit/unfetch#96
Description of how you validated changes
Local test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.