Skip to content

Commit

Permalink
address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
yuhengshs committed Nov 13, 2024
1 parent c4d3d55 commit 3cd66d6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 5 deletions.
4 changes: 2 additions & 2 deletions packages/aws-amplify/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@
"name": "[Analytics] identifyUser (Pinpoint)",
"path": "./dist/esm/analytics/index.mjs",
"import": "{ identifyUser }",
"limit": "15.95 kB"
"limit": "15.97 kB"
},
{
"name": "[Analytics] enable",
Expand Down Expand Up @@ -497,7 +497,7 @@
"name": "[Storage] uploadData (S3)",
"path": "./dist/esm/storage/index.mjs",
"import": "{ uploadData }",
"limit": "20.15 kB"
"limit": "20.17 kB"
}
]
}
1 change: 0 additions & 1 deletion packages/core/polyfills/URL/index.js

This file was deleted.

6 changes: 4 additions & 2 deletions packages/core/src/storage/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ export const getLocalStorageWithFallback = (): Storage => {
}
} catch (e) {
// Handle any errors related to localStorage access
logger.info('localStorage access failed. InMemoryStorage is used as a fallback.');
logger.info(
'localStorage not found. InMemoryStorage is used as a fallback.',
);
}

// Return in-memory storage as a fallback if localStorage is not accessible
Expand All @@ -45,7 +47,7 @@ export const getSessionStorageWithFallback = (): Storage => {
} catch (e) {
// Handle any errors related to sessionStorage access
logger.info(
'sessionStorage access failed. InMemoryStorage is used as a fallback.',
'sessionStorage not found. InMemoryStorage is used as a fallback.',
);

return new InMemoryStorage();
Expand Down

0 comments on commit 3cd66d6

Please sign in to comment.