refactor: clean signIn state after all relevant async works finish

aws-amplify · Dec 4, 2024 · 3c1cc8f · 3c1cc8f
1 parent fb8dadb
commit 3c1cc8f
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/packages/auth/src/providers/cognito/apis/confirmSignIn.ts b/packages/auth/src/providers/cognito/apis/confirmSignIn.ts
@@ -109,7 +109,6 @@ export async function confirmSignIn(
 		});
 
 		if (AuthenticationResult) {
-			cleanActiveSignInState();
 			await cacheCognitoTokens({
 				username,
 				...AuthenticationResult,
@@ -121,7 +120,8 @@ export async function confirmSignIn(
 				}),
 				signInDetails,
 			});
-
+			cleanActiveSignInState();
+
 			await dispatchSignedInHubEvent();
 
 			return {

diff --git a/packages/auth/src/providers/cognito/apis/signInWithCustomAuth.ts b/packages/auth/src/providers/cognito/apis/signInWithCustomAuth.ts
@@ -84,8 +84,6 @@ export async function signInWithCustomAuth(
 			signInDetails,
 		});
 		if (AuthenticationResult) {
-			cleanActiveSignInState();
-
 			await cacheCognitoTokens({
 				username: activeUsername,
 				...AuthenticationResult,
@@ -97,7 +95,8 @@ export async function signInWithCustomAuth(
 				}),
 				signInDetails,
 			});
-
+			cleanActiveSignInState();
+
 			await dispatchSignedInHubEvent();
 
 			return {

diff --git a/packages/auth/src/providers/cognito/apis/signInWithSRP.ts b/packages/auth/src/providers/cognito/apis/signInWithSRP.ts
@@ -91,7 +91,6 @@ export async function signInWithSRP(
 			signInDetails,
 		});
 		if (AuthenticationResult) {
-			cleanActiveSignInState();
 			await cacheCognitoTokens({
 				username: activeUsername,
 				...AuthenticationResult,
@@ -103,7 +102,8 @@ export async function signInWithSRP(
 				}),
 				signInDetails,
 			});
-
+			cleanActiveSignInState();
+
 			await dispatchSignedInHubEvent();
 
 			resetAutoSignIn();

diff --git a/packages/auth/src/providers/cognito/apis/signInWithUserAuth.ts b/packages/auth/src/providers/cognito/apis/signInWithUserAuth.ts
@@ -100,7 +100,6 @@ export async function signInWithUserAuth(
 		});
 
 		if (response.AuthenticationResult) {
-			cleanActiveSignInState();
 			await cacheCognitoTokens({
 				username: activeUsername,
 				...response.AuthenticationResult,
@@ -112,6 +111,8 @@ export async function signInWithUserAuth(
 				}),
 				signInDetails,
 			});
+			cleanActiveSignInState();
+
 			await dispatchSignedInHubEvent();
 
 			resetAutoSignIn();

diff --git a/packages/auth/src/providers/cognito/apis/signInWithUserPassword.ts b/packages/auth/src/providers/cognito/apis/signInWithUserPassword.ts
@@ -86,7 +86,6 @@ export async function signInWithUserPassword(
 			signInDetails,
 		});
 		if (AuthenticationResult) {
-			cleanActiveSignInState();
 			await cacheCognitoTokens({
 				...AuthenticationResult,
 				username: activeUsername,
@@ -98,7 +97,8 @@ export async function signInWithUserPassword(
 				}),
 				signInDetails,
 			});
-
+			cleanActiveSignInState();
+
 			await dispatchSignedInHubEvent();
 
 			resetAutoSignIn();