fix(storage): assertion for maxUrlExpiration in getUrl api (#11981)

fix(storage): assertion for maxUrlExpiration Co-authored-by: AllanZhengYP <[email protected]>
aws-amplify · Sep 6, 2023 · 2af0ca0 · 2af0ca0
1 parent 65f21cb
commit 2af0ca0
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/packages/storage/src/providers/s3/apis/internal/getUrl.ts b/packages/storage/src/providers/s3/apis/internal/getUrl.ts
@@ -10,9 +10,10 @@ import { getPresignedGetObjectUrl } from '../../utils/client';
 import { getProperties } from './getProperties';
 import { resolveS3ConfigAndInput } from '../../utils';
 import { assertValidationError } from '../../../../errors/utils/assertValidationError';
-
-const DEFAULT_PRESIGN_EXPIRATION = 900;
-const MAX_URL_EXPIRATION = 7 * 24 * 60 * 60 * 1000;
+import {
+	DEFAULT_PRESIGN_EXPIRATION,
+	MAX_URL_EXPIRATION,
+} from '../../utils/constants';
 
 export const getUrl = async function (
 	amplify: AmplifyClassV6,
@@ -37,9 +38,9 @@ export const getUrl = async function (
 		);
 		urlExpirationInSec = Math.min(awsCredExpirationInSec, urlExpirationInSec);
 	}
-
+	const maxUrlExpirationInSec = MAX_URL_EXPIRATION / 1000;
 	assertValidationError(
-		urlExpirationInSec < MAX_URL_EXPIRATION,
+		urlExpirationInSec <= maxUrlExpirationInSec,
 		StorageValidationErrorCode.UrlExpirationMaxLimitExceed
 	);