This repository has been archived by the owner on Feb 20, 2022. It is now read-only.
Small fix for setting the DateTimeFormat of an NZazu date-Field #96
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Field is created, it automatically sets the
DateTimeFormat
that is found inside of the provided Settings, and sets the wanted enum toCustom
.But with the Functions
SetProperty()
-->GetConvertedValue()
inside of the classPropertyExtensions
the Value will be checked again and will fail most of the time, because theEnumConverter
is not able to convert theDateFormatString
into an Enum, and will leave the users confused as to why an error is traced, but the Field with its Formats still works (because it was set before insode ofXceedDateTimeField
)This change will fix that by setting the Format-Setting to the appropriate
Custom
DateTimeFormat-Enum