Skip to content
This repository has been archived by the owner on Feb 20, 2022. It is now read-only.

Small fix for setting the DateTimeFormat of an NZazu date-Field #96

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Small fix for setting the DateTimeFormat of an NZazu date-Field #96

merged 1 commit into from
Feb 15, 2019

Conversation

wgnf
Copy link
Contributor

@wgnf wgnf commented Feb 15, 2019

When the Field is created, it automatically sets the DateTimeFormat that is found inside of the provided Settings, and sets the wanted enum to Custom.

But with the Functions SetProperty() --> GetConvertedValue() inside of the class PropertyExtensions the Value will be checked again and will fail most of the time, because the EnumConverter is not able to convert the DateFormatString into an Enum, and will leave the users confused as to why an error is traced, but the Field with its Formats still works (because it was set before insode of XceedDateTimeField)
This change will fix that by setting the Format-Setting to the appropriate Custom DateTimeFormat-Enum

When the Field is created, it automatically sets the DateTimeFormat that is found inside of the provided Settings, and sets the wanted enum to "Custom".

But with the Function SetProperty() --> GetConvertedValue() inside of the class PropertyExtensions the Value will be checked again and will fail most of the time, and leave the users confused as to why an error is Traced.
This change will fix that
@coveralls
Copy link

Pull Request Test Coverage Report for Build 75cr14wgwp4hqi8w

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 80.027%

Totals Coverage Status
Change from base Build 44rhw735m7y0vgny: -0.5%
Covered Lines: 3590
Relevant Lines: 4486

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 75cr14wgwp4hqi8w

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 80.576%

Totals Coverage Status
Change from base Build 44rhw735m7y0vgny: 0.008%
Covered Lines: 3750
Relevant Lines: 4654

💛 - Coveralls

@wgnf
Copy link
Contributor Author

wgnf commented Feb 15, 2019

As of my understanding these errors that prevent the check from being successfull are not happening because of my changes, but are results of the refactoring of some of the Validation Mechanisms. These Commits are affected, as of my "research":

(All checks after the commit 0398757 are failing)

@mkoertgen
Copy link
Member

Looks good. Keep up the good work! 👍

@mkoertgen mkoertgen merged commit 2b86504 into awesome-inc:master Feb 15, 2019
@wgnf wgnf deleted the datetime_format_fix branch February 19, 2019 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants