This repository has been archived by the owner on Feb 20, 2022. It is now read-only.
Fix AutoCompleteManager's ResourceDictionary loading #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from Origin
Previously the Resource-Dictionary was every single time the "AutoCompleteManager" was initialized, because the "FindName" Method of a ResourceDictionary was used. According to Microsoft's Documentation: https://docs.microsoft.com/de-de/dotnet/api/system.windows.resourcedictionary.findname?view=netframework-4.8 This Method always returns null, because Keys are used in a Dictionary. That's why this piece of code was faulty.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
ResourceDictionaryfor the ListBox was added every single time theAutoCompleteManagerwas initialized, because theFindNameMethod of aResourceDictionarywas used. According to Microsoft's Documentation:https://docs.microsoft.com/de-de/dotnet/api/system.windows.resourcedictionary.findname?view=netframework-4.8
This Method always returns
null, because Keys are used in a Dictionary. That's why this piece of code was faulty.I've chagned this particular usage to "Contains" which uses the default Dictionary-approach.
This also fixes a rare edge-case for me, where the private variable "_resizeGrip" would not be initialized and so will result in some
NullReferenceExceptions