This repository has been archived by the owner on Feb 20, 2022. It is now read-only.
Check Nulls on "AutoCompletManager" #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from Origin
When using the "autocomplete" field in one of our templates, we learned, that there are some cases where the internal variables of the "AutoCompleteManager" - such as "_textBox", "_scrollViewer", "_resizeGrip", "_scrollBar" - can be null in some edge cases. I've yet to analyze why that happens sometimes, but i figured it would be a good idea to add some null-checks when using those variables, before this component throws some "NullReferenceException"s that the consumer has to handle.
|
After a discussion, this should not be done this way. First of all we should find the source of the error, before "hiding" the problem with those null checks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
autocompletefield in one of our templates, we learned, that there are some cases where the internal variables of theAutoCompleteManager- such as_textBox,_scrollViewer,_resizeGrip,_scrollBar- can be null in some edge cases. I've yet to analyze why that happens sometimes, but i figured it would be a good idea to add some null-checks when using those variables, before this component throws someNullReferenceExceptions that the consumer has to handle.