Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/follow #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Feat/follow #16

wants to merge 1 commit into from

Conversation

namanhph-0449
Copy link

Checklist tự review pull trước khi ready để trainer review

  • Kiểm tra mỗi pull request chỉ 1 commit, nếu nhiều hơn 1 commit thì hãy gộp commit thành 1 rồi đẩy lại lên git
  • Chạy eslint ở local để check và fix các lỗi liên quan đến syntax, coding convention. Khi gửi thì chụp ảnh PASS eslint đính kèm trong pull
  • Sử dụng thụt lề 2 spaces/4 spaces đồng nhất ở tất cả các files (setting lại vscode /sublime text nếu chưa cài đặt)
  • Cuối mỗi file kiểm tra có end line (khi đẩy lên git xem file change không bị lỗi tròn đỏ ở cuối file)
  • Mỗi dòng nếu quá dài, cần xuống dòng (maximum: 80 kí tự mỗi dòng, setting trong IDE hoặc dùng Prettier để config format code)
  • Tham khảo Typescript coding convention https://google.github.io/styleguide/tsguide.html

Related Tickets

@namanhph-0449
Copy link
Author

ready

huongnt-2545
huongnt-2545 reviewed Sep 9, 2024
View reviewed changes
Copy link
Contributor

@huongnt-2545 huongnt-2545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull đang có 2 commits, e rebase code mới nhất về đi nhé

@namanhpham namanhpham force-pushed the feat/follow branch 2 times, most recently from 115b155 to 6b20f0f Compare September 10, 2024 12:27
@namanhph-0449
Copy link
Author

ready

huongnt-2545
huongnt-2545 reviewed Sep 11, 2024
View reviewed changes
src/app.ts
@@ -37,6 +38,11 @@ hbs.registerHelper('t', (key: string) => {
return i18next.t(key);
});

hbs.registerHelper('isFollowing', function(user: User, followingUsers: Array<User>) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

helper này để làm gì e?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
em dùng để check xem có đang follow user nào đó không thì sẽ hiển thị nút unfollow ạ

src/public/js/script.js Outdated Show resolved Hide resolved
src/public/js/script.js Outdated Show resolved Hide resolved
src/public/js/script.js Outdated Show resolved Hide resolved
src/public/js/script.js Outdated Show resolved Hide resolved
src/public/js/script.js Outdated Show resolved Hide resolved
@namanhph-0449
Copy link
Author

reay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huongnt-2545 huongnt-2545 huongnt-2545 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@namanhph-0449 @huongnt-2545 @namanhpham