Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User payment #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

PluckySquirrel
Copy link
Contributor

Checklist tự review pull trước khi ready để trainer review

  • Kiểm tra mỗi pull request chỉ 1 commit, nếu nhiều hơn 1 commit thì hãy gộp commit thành 1 rồi đẩy lại lên git
  • Chạy eslint ở local để check và fix các lỗi liên quan đến syntax, coding convention. Khi gửi thì chụp ảnh PASS eslint đính kèm trong pull
  • Sử dụng thụt lề 2 spaces/4 spaces đồng nhất ở tất cả các files (setting lại vscode /sublime text nếu chưa cài đặt)
  • Cuối mỗi file kiểm tra có end line (khi đẩy lên git xem file change không bị lỗi tròn đỏ ở cuối file)
  • Mỗi dòng nếu quá dài, cần xuống dòng (maximum: 80 kí tự mỗi dòng, setting trong IDE hoặc dùng Prettier để config format code)
  • Tham khảo Typescript coding convention https://google.github.io/styleguide/tsguide.html

Related Tickets

- ticket redmine

WHAT (optional)

  • Change number items completed/total in admin page.

HOW

  • I edit js file, inject not_vary_normal items in calculate function.

WHY (optional)

  • Because in previous version - number just depends on normal items. But in new version, we have state and confirm_state depends on both normal + not_normal items.

Evidence (Screenshot or Video)

462332378_1051466789808046_8008352509836283154_n
462541633_1508436796524238_8545163198390170707_n

Notes (Kiến thức tìm hiểu thêm)

@PluckySquirrel
Copy link
Contributor Author

ready

@huongnt-2545
Copy link
Contributor

conflicted

@PluckySquirrel
Copy link
Contributor Author

ready

Comment on lines +88 to +89
res.status(404).json({ message: 'User not found' });
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res.status(404).json({ message: 'User not found' });
return;
return res.status(404).json({ message: 'User not found' });

Comment on lines +94 to +95
res.status(404).json({ message: 'Course not found' });
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
res.status(404).json({ message: 'Course not found' });
return;
return res.status(404).json({ message: 'Course not found' });

Comment on lines +12 to +13
res.status(404).json({ message: "Payment not found or not authorized" });
return;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sửa tương tự e nha
I18n các message nữa nhé

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants