Fix response integrity check bug (#23) and fix missing tests data #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is being made because the `Docker-Content-Digest` value sent back by docker distribution is a hash digest from the image manifest list when only the image manifest is accepted by the client. This issue on docker distribution tracks the regression: distribution/distribution#2395 Fixes #23 Issue #24 tracks reverting this change when the docker distribution issue is resolved.
This fixes a test failure caused by the tests data dir not being included in the cabal source distribution.
intractable
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is being made because the
Docker-Content-Digestvalue sent back by docker distribution is a hash digest from the image manifest list when only the image manifest is accepted by the client.This issue on docker distribution tracks the regression: distribution/distribution#2395
Fixes #23
Issue #24 tracks reverting this change when the docker distribution issue is resolved.
This change also fixes a test failure caused by the tests data dir not being included in the cabal source distribution.