hocker-config and hocker-layer should check the integrity of docker distribution's response #24
Assignees
Comments
ixmatus
added a commit
that referenced
this issue
Dec 1, 2017
This change is being made because the `Docker-Content-Digest` value sent back by docker distribution is a hash digest from the image manifest list when only the image manifest is accepted by the client. This issue on docker distribution tracks the regression: distribution/distribution#2395 Fixes #23 Issue #24 tracks reverting this change when the docker distribution issue is resolved.
ixmatus
added a commit
that referenced
this issue
Dec 1, 2017
* Remove response integrity check of config.json and layer This change is being made because the `Docker-Content-Digest` value sent back by docker distribution is a hash digest from the image manifest list when only the image manifest is accepted by the client. This issue on docker distribution tracks the regression: distribution/distribution#2395 Fixes #23 Issue #24 tracks reverting this change when the docker distribution issue is resolved. * Add the hocker tests data files This fixes a test failure caused by the tests data dir not being included in the cabal source distribution.
ixmatus
added a commit
that referenced
this issue
Feb 11, 2018
In commit 63129b1 I removed the check for the function that fetches layers but did not remove it for the function that fetches a whole image. This change is being made because the `Docker-Content-Digest` value sent back by docker distribution is a hash digest from the image manifest list when only the image manifest is accepted by the client. This issue on docker distribution tracks the regression: distribution/distribution#2395 Fixes #23 Issue #24 tracks reverting this change when the docker distribution issue is resolved. This change also fixes a test failure caused by the tests data dir not being included in the cabal source distribution.
ixmatus
added a commit
that referenced
this issue
Feb 12, 2018
* Remove the response integrity check In commit 63129b1 I removed the check for the function that fetches layers but did not remove it for the function that fetches a whole image. This change is being made because the `Docker-Content-Digest` value sent back by docker distribution is a hash digest from the image manifest list when only the image manifest is accepted by the client. This issue on docker distribution tracks the regression: distribution/distribution#2395 Fixes #23 Issue #24 tracks reverting this change when the docker distribution issue is resolved. This change also fixes a test failure caused by the tests data dir not being included in the cabal source distribution. * Fix the incorrect serialization of the registry URI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When the regression in docker distribution (#2395) is fixed, the response integrity check should be put back in.
Note that #23 tracks removing the response integrity check to fix the
hocker-configandhocker-layerfailures.The text was updated successfully, but these errors were encountered: