feat(playstore): add pointer in DeveloperNotification #268
Conversation
…ductNotification, VoidedPurchaseNotification, TestNotification in DeveloperNotification
If these three parameters are not set as pointers, it won't be possible to determine if they are nil. So, in that case, how can I determine the type of notification received? |
|
Thanks for your response. var noti DeveloperNotification
/// received
if noti.OneTimeProductNotification.Version != "" {
// this is OneTime Notification
} |
However, according to the official documentation, these fields are actually mutually exclusive. So, my idea is to use pointers to determine if they are nil, which can also determine the type of notification. If we were to judge whether a specific field inside is an empty string, it would lead to misunderstanding. Moreover, each person may judge different fields, which would lack standardization. |
|
I understood 👍 |
Okay, I'll try to make some modifications. Thank you for your response. It's my first time submitting a PR on GitHub. If there's anything I've done wrong, please feel free to point it out. |
I added a struct DeveloperNotificationNew. Can you see if this works? |
playstore/notification.go
Outdated
| // DeveloperNotificationNew is sent by a Pub/Sub topic. | ||
| // Detailed description is following. | ||
| // https://developer.android.com/google/play/billing/rtdn-reference#json_specification | ||
| type DeveloperNotificationNew struct { |
There was a problem hiding this comment.
Can it be DeveloperNotificationV2 as New may cause confusion at a later date? 🙏
There was a problem hiding this comment.
Can it be
DeveloperNotificationV2asNewmay cause confusion at a later date? 🙏
ok
playstore/notification.go
Outdated
| @@ -38,6 +38,7 @@ const ( | |||
| // DeveloperNotification is sent by a Pub/Sub topic. | |||
| // Detailed description is following. | |||
| // https://developer.android.com/google/play/billing/rtdn-reference#json_specification | |||
| // Deprecated | |||
There was a problem hiding this comment.
Deprecated comments should be Deprecated: .
For example, Depreacated: use DeveloperNotificationV2 intead.
It would be kind to do it this way
https://go.dev/wiki/Deprecated
There was a problem hiding this comment.
Depreacated: use DeveloperNotificationV2 intead.
A colon + space is required after the Deprecated character.
And please write on one line 🙏
In this format, the editors will issue a warning.
…ionV2;modify comment
|
Thank you for your correction. I have modified it. Please check whether it complies with the specifications. |
| // DeveloperNotificationV2 is sent by a Pub/Sub topic. | ||
| // Detailed description is following. | ||
| // https://developer.android.com/google/play/billing/rtdn-reference#json_specification | ||
| type DeveloperNotificationV2 struct { |
playstore/notification.go
Outdated
| @@ -38,6 +38,7 @@ const ( | |||
| // DeveloperNotification is sent by a Pub/Sub topic. | |||
| // Detailed description is following. | |||
| // https://developer.android.com/google/play/billing/rtdn-reference#json_specification | |||
| // Deprecated | |||
There was a problem hiding this comment.
Depreacated: use DeveloperNotificationV2 intead.
A colon + space is required after the Deprecated character.
And please write on one line 🙏
In this format, the editors will issue a warning.
|
I have modified it. Please help me check whether it conforms to the specifications. Thank you. |
| @@ -38,6 +38,7 @@ const ( | |||
| // DeveloperNotification is sent by a Pub/Sub topic. | |||
| // Detailed description is following. | |||
| // https://developer.android.com/google/play/billing/rtdn-reference#json_specification | |||
| // Depreacated: use DeveloperNotificationV2 instead. | |||
add pointer for SubscriptionNotification, OneTimeProductNotification, VoidedPurchaseNotification, TestNotification in DeveloperNotification