Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding arduino_packing_release github action #1690

Merged
merged 13 commits into from
Apr 13, 2024

Conversation

mcuee
Copy link
Collaborator

@mcuee mcuee commented Feb 17, 2024

As of now, the existing arduino_packing action is only executed upon push to git main, but not release tagging.
https://github.com/avrdudes/avrdude/blob/main/.github/workflows/arduino_packing.yml

This PR adds the github action upon tagging a release like v7.4.

Note: please use `Squash and merge" for this PR.

@mcuee mcuee added the enhancement New feature or request label Feb 17, 2024
@mcuee
Copy link
Collaborator Author

mcuee commented Feb 17, 2024

@umbynos

Please review this. I think this may not be the best solution and it is probably better to include this function into the existing script.

@mcuee mcuee changed the title Arduino packing release test Adding arduino_packing_release github action Feb 17, 2024
@mcuee mcuee changed the title Adding arduino_packing_release github action Adding arduino_packing_release github action Feb 17, 2024
@mcuee mcuee marked this pull request as draft February 23, 2024 11:29
Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long, I've made some suggestions. This of course probably needs a test run to be sure everything works just fine

.github/workflows/arduino_packing_release.yml Outdated Show resolved Hide resolved
.github/workflows/arduino_packing_release.yml Outdated Show resolved Hide resolved
.github/workflows/arduino_packing_release.yml Outdated Show resolved Hide resolved
.github/workflows/arduino_packing_release.yml Outdated Show resolved Hide resolved
.github/workflows/arduino_packing_release.yml Show resolved Hide resolved
.github/workflows/arduino_packing_release.yml Outdated Show resolved Hide resolved
@MCUdude
Copy link
Collaborator

MCUdude commented Mar 20, 2024

Noob question: Will it be possible to statically link against our fork of libserialport, which has that nasty macOS bug resolved?

@mcuee
Copy link
Collaborator Author

mcuee commented Mar 20, 2024

Noob question: Will it be possible to statically link against our fork of libserialport, which has that nasty macOS bug resolved?

As of now, I do not know how to cross-compile libserialport under macOS. Hopefully @umbynos can help here. After that we can use our fork.

Reference:

@umbynos
Copy link
Contributor

umbynos commented Mar 20, 2024

Noob question: Will it be possible to statically link against our fork of libserialport, which has that nasty macOS bug resolved?

Yeah, for that you can use an approach similar to the one I used in the build_libs.sh script. You can do that in the workflow directly

@stefanrueger
Copy link
Collaborator

@mcuee Just checking whether this PR is still a draft despite recent commits last week

@mcuee
Copy link
Collaborator Author

mcuee commented Mar 29, 2024

@mcuee Just checking whether this PR is still a draft despite recent commits last week

Still a draft -- missing one change now.

@mcuee
Copy link
Collaborator Author

mcuee commented Mar 29, 2024

I believe this is ready for review now.

@mcuee mcuee marked this pull request as ready for review March 29, 2024 10:38
@mcuee
Copy link
Collaborator Author

mcuee commented Mar 29, 2024

@umbynos

Please carry out a sanity check to see the latest commit is okay or not. Thanks.

@mcuee
Copy link
Collaborator Author

mcuee commented Mar 29, 2024

@stefanrueger

Once @umbynos reviews this PR and says OK, you can merge it. Please use "Squash and merge" option for this PR. Thanks.

mcuee added a commit to mcuee/avrdude that referenced this pull request Mar 29, 2024
This is pointed out by @umbynos during the review of PR avrdudes#1690
@mcuee
Copy link
Collaborator Author

mcuee commented Apr 5, 2024

@umbynos

Please help to double check this PR. Thanks.

@umbynos
Copy link
Contributor

umbynos commented Apr 5, 2024

I would trigger a test release, just to be sure everything works

@mcuee
Copy link
Collaborator Author

mcuee commented Apr 5, 2024

I would trigger a test release, just to be sure everything works

In that case, do we need to merge this PR first and then trigger a test release?

@mcuee
Copy link
Collaborator Author

mcuee commented Apr 7, 2024

@umbynos

I thought I fixed the CI build issue here in commit mcuee@1a04644.
https://github.com/mcuee/avrdude/actions/runs/8586853035/job/23529789940

Run mkdir -p _Linux_ARMv6/bin _Linux_ARMv6/etc
renamed 'build/src/' -> '_Linux_ARMv6/bin/src'
mv: cannot stat 'build/src/.conf': No such file or directory
Error: Process completed with exit code 1.

But now I can not see the CI being trigged when I tagged a pre-release v7.4snapshot20240407.
https://github.com/mcuee/avrdude/actions

Edit -- false alarm -- I wrongly tagged the main branch.

@mcuee
Copy link
Collaborator Author

mcuee commented Apr 7, 2024

@umbynos

But github CI build is still faling. Please help to check what is going wrong. Thanks a lot for the help in advance.
https://github.com/mcuee/avrdude/actions/runs/8586938423

@mcuee
Copy link
Collaborator Author

mcuee commented Apr 7, 2024

@umbynos

Now CI is good. Please carry out a final review to see if it is good to go. Thanks.
https://github.com/mcuee/avrdude/actions/runs/8587135306

Copy link
Contributor

@umbynos umbynos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcuee
Copy link
Collaborator Author

mcuee commented Apr 8, 2024

@stefanrueger

Now it should be good to go. Please use Squash and merge. Thanks.

@stefanrueger stefanrueger merged commit d441501 into avrdudes:main Apr 13, 2024
12 checks passed
@mcuee mcuee deleted the arduino_packing_release_test branch April 23, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants