-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding arduino_packing_release
github action
#1690
Adding arduino_packing_release
github action
#1690
Conversation
Please review this. I think this may not be the best solution and it is probably better to include this function into the existing script. |
arduino_packing_release
github action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long, I've made some suggestions. This of course probably needs a test run to be sure everything works just fine
Co-authored-by: Umberto Baldi <[email protected]>
Co-authored-by: Umberto Baldi <[email protected]>
Co-authored-by: Umberto Baldi <[email protected]>
Co-authored-by: Umberto Baldi <[email protected]>
Co-authored-by: Umberto Baldi <[email protected]>
Noob question: Will it be possible to statically link against our fork of libserialport, which has that nasty macOS bug resolved? |
As of now, I do not know how to cross-compile libserialport under macOS. Hopefully @umbynos can help here. After that we can use our fork. Reference: |
Yeah, for that you can use an approach similar to the one I used in the |
@mcuee Just checking whether this PR is still a draft despite recent commits last week |
Still a draft -- missing one change now. |
I believe this is ready for review now. |
Please carry out a sanity check to see the latest commit is okay or not. Thanks. |
Once @umbynos reviews this PR and says OK, you can merge it. Please use "Squash and merge" option for this PR. Thanks. |
This is pointed out by @umbynos during the review of PR avrdudes#1690
Please help to double check this PR. Thanks. |
I would trigger a test release, just to be sure everything works |
In that case, do we need to merge this PR first and then trigger a test release? |
I thought I fixed the CI build issue here in commit mcuee@1a04644.
But now I can not see the CI being trigged when I tagged a pre-release Edit -- false alarm -- I wrongly tagged the main branch. |
But github CI build is still faling. Please help to check what is going wrong. Thanks a lot for the help in advance. |
Now CI is good. Please carry out a final review to see if it is good to go. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now it should be good to go. Please use |
As of now, the existing arduino_packing action is only executed upon push to git main, but not release tagging.
https://github.com/avrdudes/avrdude/blob/main/.github/workflows/arduino_packing.yml
This PR adds the github action upon tagging a release like
v7.4
.Note: please use `Squash and merge" for this PR.