Reduce stk500v2_getsync() timeout #1506
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serial reads utilise a global variable
serial_recv_timeout
, which is set to 5 s by default. Anystk500v2_getsync()
attempt that fails because the board took longer to come out of reset than AVRDUDE had bargained for and therefore missed the sync command will out of necessity be blocked for 5 s. This is far too long. This PR reduces the serial receive timeout to 200 ms, which should be long enough for most comms, even if the data have to swirl around through wifi packets...This also gets
-c wiring
to fail quicker in case the target board does not have a wiring bootloader or cannot trigger reset from DTR/RTS lines.