Fix data race in h.samplingRate #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioutil.ReadAll() has been deprecated since Go 1.16
By holding the tracking endpoint as part of AvoNetworkCallsHandler we are able to change it for test purposes and thus we're able to add coverage for callInspectorWithBatchBody()
If the Avo inspector handler is used concurrently by different go-routines then the h.samplingRate can have race conditions where it's trying to be read/written at the same time
The new test can be executed using:
go test -run TestAvoNetworkCallsHandler_callInspectorWithBatchBody -race -timeout 3s
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10
The Avo inspector handler can't be used concurrently given that
h.samplingRateallows for race conditions where different go-routines can read it and/or write to it.It's being read here and written here.
In
avoNetworkCallsHandler_test.gowe're adding coverage to assert that no race condition happens when the inspector is used concurrently by different go-routines.