Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: improve 'all' stream and 'full.log' docs #6050

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smitterl
Copy link
Contributor

Add a few sentences that hopefully help to understand which file to look into for the 'legacy' behavior of the job.log, e.g. in 93lts.

Add a few sentences that hopefully help to understand which
file to look into for the 'legacy' behavior of the job.log, e.g.
in 93lts.

Signed-off-by: Sebastian Mitterle <[email protected]>
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.46%. Comparing base (d5569ca) to head (63f49c1).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6050      +/-   ##
==========================================
- Coverage   54.47%   54.46%   -0.01%     
==========================================
  Files         202      202              
  Lines       21874    21885      +11     
==========================================
+ Hits        11915    11919       +4     
- Misses       9959     9966       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richtja
Copy link
Contributor

richtja commented Oct 29, 2024

Hi @smitterl, thank you for this, documentation updates are always welcome. Can you please give me more details about what are you missing in the documentation? Because your updates are related to full.log file and all stream and that should be always enabled, even if users use --store-logging-stream option, and that is described in here. Maybe instead of talking about all stream, we just need to add links to the full.log description.

@richtja
Copy link
Contributor

richtja commented Nov 27, 2024

Hi @smitterl, gentle ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review Requested
Development

Successfully merging this pull request may close these issues.

2 participants