-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 #201
Open
samrodriguez
wants to merge
37
commits into
avalanche123:master
Choose a base branch
from
samrodriguez:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Patch 1 #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add crop filter implementation
catch exception when invalid filter is used
added missing use statement
Relation to develop branch of "avalanche123/Imagine"
Only the first-level array was merged, if two different filters were defined in different config array, only one was kept.
Merge recursively the config
Fixing bug when verifying cached content + concurrency related issue.
fixed link to imagine library
source_root can be overrided in filter options.
…generated images.
Add permissions configuration setting to set specific chmod value on gen...
Check if $cached is not a directory to avoid error on unlink
Fixed bug with symfony 2.3
Update README.md with instruction to create a cache image from controllers.
Updated installation instructions via composer to use the `composer require` command without specifying a version. This is the new recommended way of providing this information and it leads to composer picking the proper version constraint (i.e ~1.2), updating the `composer.json` and running install, all in one command.
Add sourceRoot to the imagine.cache.path.resolver.class
Replace webRoot to sourceRoot in realPath
Update README.md
Mistake in clear cache in CachePathResolver
…n 1.12 DEPRECATION - The Twig_Filter_Method class is deprecated since version 1.12 and will be removed in 2.0. Use Twig_SimpleFilter instead
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEPRECATION - The Twig_Filter_Method class is deprecated since version 1.12