Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates and ESM support #36

Merged
merged 9 commits into from
Nov 2, 2021
Merged

Updates and ESM support #36

merged 9 commits into from
Nov 2, 2021

Conversation

novemberborn
Copy link
Member

@novemberborn novemberborn commented Nov 1, 2021

Fixes #5.

  • Simplify issue template
  • Upgrade XO and apply changes
  • Update dependencies
  • Upgrade to ESM
  • Match AVA 4 Node.js versions
  • Update CI
  • Support ESM files

@novemberborn
Copy link
Member Author

novemberborn commented Nov 1, 2021

Thwarted by CI failures! Why the heck is this failing in Node.js 12 and 14, but not locally?! https://github.com/avajs/typescript/runs/4072812179?check_suite_focus=true

Sure I can add "lib": ["es2015"] but that breaks linting: https://github.com/avajs/typescript/runs/4072834457?check_suite_focus=true

And why is it complaining about an ESLint type definition anyhow.

@sindresorhus
Copy link
Member

Thwarted by CI failures! Why the heck is this failing in Node.js 12 and 14, but not locally?!

Since it's only failing on Node.js 12 and 14, which use npm 6, not 7, I would guess it has something to do with dependency resolution. I had a lot of problems with npm 6 in XO... Try forcing the latest npm version maybe?

@sindresorhus
Copy link
Member

Unrelated by both actions/checkout@v1, actions/setup-node@v1, and codecov/codecov-action@v1 can be bumped to v2.

@novemberborn
Copy link
Member Author

Since it's only failing on Node.js 12 and 14, which use npm 6, not 7, I would guess it has something to do with dependency resolution. I had a lot of problems with npm 6 in XO... Try forcing the latest npm version maybe?

Yes, that does the trick! Well spotted.

Unrelated by both actions/checkout@v1, actions/setup-node@v1, and codecov/codecov-action@v1 can be bumped to v2.

Already taken care of in this PR 😄

@novemberborn novemberborn merged commit 16eeb96 into main Nov 2, 2021
@novemberborn novemberborn deleted the updates branch November 2, 2021 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ESM test files
2 participants