Move classes from jdk package into core so that less need to be public #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few classes like JdkContext needed to be public because they where in the jdk package and moving them to core allows them to be non-public
|
I mean they aren't exported so they aren't accessible anyways |
SentryMan
approved these changes
Dec 2, 2024
Accessible via classpath though, and not as "tight" as it could be / making more classes explicitly non-public gives a better feel for the design imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few classes like JdkContext needed to be public because they where in the jdk package and moving them to core allows them to be non-public