Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: vm.Hooks.OverrideEVMResetArgs() receives params.Rules #38

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

ARR4N
Copy link
Collaborator

@ARR4N ARR4N commented Sep 26, 2024

Why this should be merged

coreth integration of libevm requires access to params.Rules when overriding the EVM reset.

How this works

Existing plumbing with extended hook signature.

How this was tested

Existing unit test extended to record chain ID received via Rules.

@ARR4N ARR4N marked this pull request as ready for review September 26, 2024 09:33
@ARR4N ARR4N requested review from a team, darioush, ceyonur and michaelkaplan13 and removed request for a team September 26, 2024 10:12
@ARR4N ARR4N merged commit 99a755f into libevm Sep 26, 2024
3 checks passed
@ARR4N ARR4N deleted the arr4n/evm-reset-rules branch September 26, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants