feat: CheckConfig{Compatible,ForkOrder} + Description hooks
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
requested review from
a team,
darioush,
ceyonur and
michaelkaplan13
and removed request for
a team
darioush
approved these changes
Sep 17, 2024
Comment on lines
-62
to
-64
| // (Optional) If not all hooks are desirable then embedding a [NOOPHooks] | ||
| // allows the type to satisfy the [RulesHooks] interface, resulting in | ||
| // default Ethereum behaviour. |
There was a problem hiding this comment.
should we keep this comment?
There was a problem hiding this comment.
It's just been moved to ChainConfigExtra. I didn't think it was necessary to include it twice in the example, and that it should be at the first appearance of NOOPHooks.
Co-authored-by: Darioush Jalali <[email protected]> Signed-off-by: Arran Schlosberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Closes #21
How this works
New methods on
params.ChainConfigHooks, each plugged into the end of their respective methods.The
CheckConfigCompatiblehook has the same signature as theparams.CheckCompatiblemethod, but this can be updated if we find that we need access to the oldChainConfig.How this was tested
Unit tests of each hook demonstrate the difference compared to when they aren't registered.