forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* feat: `vm.MutableStack` wrapper * refactor: use `require.Empty()`
- Loading branch information
Showing
2 changed files
with
41 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package vm | ||
|
||
import "github.com/holiman/uint256" | ||
|
||
// A MutableStack embeds a Stack to expose unexported mutation methods. | ||
type MutableStack struct { | ||
*Stack | ||
} | ||
|
||
// Push pushes a value to the stack. | ||
func (s MutableStack) Push(d *uint256.Int) { s.Stack.push(d) } | ||
|
||
// Pop pops a value from the stack. | ||
func (s MutableStack) Pop() uint256.Int { return s.Stack.pop() } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package vm_test | ||
|
||
import ( | ||
"testing" | ||
|
||
"github.com/holiman/uint256" | ||
"github.com/stretchr/testify/require" | ||
|
||
"github.com/ethereum/go-ethereum/core/vm" | ||
) | ||
|
||
func TestMutableStack(t *testing.T) { | ||
s := &vm.Stack{} | ||
m := vm.MutableStack{Stack: s} | ||
|
||
push := func(u uint64) uint256.Int { | ||
u256 := uint256.NewInt(u) | ||
m.Push(u256) | ||
return *u256 | ||
} | ||
|
||
require.Empty(t, s.Data(), "new stack") | ||
want := []uint256.Int{push(42), push(314159), push(142857)} | ||
require.Equalf(t, want, s.Data(), "after pushing %d values to empty stack", len(want)) | ||
require.Equal(t, want[len(want)-1], m.Pop(), "popped value") | ||
require.Equal(t, want[:len(want)-1], s.Data(), "after popping a single value") | ||
} |