-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: P-chain dynamic fees #74
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meeh0w
force-pushed
the
feat/pchain-dynamic-fees
branch
from
October 24, 2024 07:11
01916e3
to
649521c
Compare
meeh0w
force-pushed
the
feat/pchain-dynamic-fees
branch
from
October 30, 2024 08:24
b25d1d4
to
b44129c
Compare
meeh0w
commented
Oct 31, 2024
meeh0w
commented
Oct 31, 2024
meeh0w
commented
Oct 31, 2024
meeh0w
commented
Oct 31, 2024
meeh0w
commented
Nov 4, 2024
({ chainId, networkBalances }) => | ||
!isEqual(networkBalances, this.balances[chainId]) | ||
) | ||
.filter(({ chainId, networkBalances }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes a bug I've noticed in the P-Chain balances fetching.
Basically, when user has multiple accounts derived, we would always detect changes here because we only poll for the active account and we'd have balances for multiple addresses cached.
meeh0w
commented
Nov 4, 2024
meeh0w
commented
Nov 4, 2024
src/background/services/network/utils/isAvalanchePchainNetwork.ts
Outdated
Show resolved
Hide resolved
meeh0w
commented
Nov 4, 2024
bferenc
previously approved these changes
Nov 18, 2024
bferenc
approved these changes
Nov 21, 2024
gergelylovas
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
TODOs
Changes
getProviderForNetwork()
util to be async, since we now need to fetch theupgradesInfo
object firstAccountsService
&SecretsService
so that account addresses are recalculated if devnet is selected (X/P chain prefix is different -custom
)CustomFees
component to allow making it collapsible:collapsible = true
, it shows as collapsed by default (only the case P-Chain send screen with Etna upgrade activated)Testing
fuji
prefixcustom
prefixBackwards compatibility
Etna upgrade compatibility
Avalanche Etna P-Devnet
firstChecklist for the author