Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bring back address copy button #110

Merged
merged 2 commits into from
Dec 13, 2024
Merged

feat: bring back address copy button #110

merged 2 commits into from
Dec 13, 2024

Conversation

meeh0w
Copy link
Member

@meeh0w meeh0w commented Dec 12, 2024

Description

  • Brings back the copy address button to the account switcher.

Testing

  • Use the address copy button and make sure it works
  • Bonus points for verifying the captured event names

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

gergelylovas
gergelylovas previously approved these changes Dec 12, 2024
Copy link
Contributor

@gergelylovas gergelylovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy button works well. I wonder if we could make the address selectable in the tooltip as well. I think it was possible in one of the previous iterations of the current redesign.

Screen.Recording.2024-12-12.at.11.29.03.mov

src/pages/Accounts/components/AccountItem.tsx Outdated Show resolved Hide resolved
@meeh0w meeh0w merged commit 63a677b into main Dec 13, 2024
5 of 6 checks passed
@meeh0w meeh0w deleted the feat/acc-switcher-copy branch December 13, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants