test: add test scenarios for wallet balance fetching

src/background/services/balances/handlers/getTotalBalanceForWallet/getTotalBalanceForWallet.ts

@@ -18,7 +18,7 @@ import {
   isImportedAccountsRequest,
 } from './models';
 import {
-  calculateTotalBalanceForAddresses,
+  calculateTotalBalanceForAccounts,
   getAccountsWithActivity,
   getAllAddressesForAccounts,
   getIncludedNetworks,
@@ -61,7 +61,7 @@ export class GetTotalBalanceForWalletHandler implements HandlerType {
       addr.replace(/^[PXC]-/i, '')
     );
     const underivedXPChainAddresses = secrets.xpubXP
-      ? Object.keys(
+      ? (
           await getAccountsWithActivity(
             secrets.xpubXP,
             await this.networkService.getAvalanceProviderXP(),
@@ -114,7 +114,7 @@ export class GetTotalBalanceForWalletHandler implements HandlerType {
           [TokenType.NATIVE, TokenType.ERC20]
         );
 
-      let totalBalanceInCurrency = calculateTotalBalanceForAddresses(
+      let totalBalanceInCurrency = calculateTotalBalanceForAccounts(
         derivedAddressesBalances,
         derivedAccounts,
         networksIncludedInTotal
@@ -134,7 +134,7 @@ export class GetTotalBalanceForWalletHandler implements HandlerType {
             false // Don't cache this
           );
 
-        const underivedAccountsTotal = calculateTotalBalanceForAddresses(
+        const underivedAccountsTotal = calculateTotalBalanceForAccounts(
           underivedAddressesBalances,
           underivedAccounts,
           getXPChainIds(this.networkService.isMainnet())

src/background/services/balances/handlers/getTotalBalanceForWallet/helpers/calculateTotalBalanceForAccounts.test.ts

@@ -0,0 +1,97 @@
+import { Account } from '@src/background/services/accounts/models';
+import { calculateTotalBalance } from '@src/utils/calculateTotalBalance';
+
+import { calculateTotalBalanceForAccounts } from './calculateTotalBalanceForAccounts';
+
+jest.mock('@src/utils/calculateTotalBalance');
+
+describe('src/background/services/balances/handlers/helpers/calculateTotalBalanceForAccounts', () => {
+  it('aggregates results of calculateTotalBalance() for provided accounts', () => {
+    jest
+      .mocked(calculateTotalBalance)
+      .mockReturnValueOnce({
+        sum: 100,
+        priceChange: {
+          percentage: [0],
+          value: 0,
+        },
+      })
+      .mockReturnValueOnce({
+        sum: 0,
+        priceChange: {
+          percentage: [0],
+          value: 0,
+        },
+      })
+      .mockReturnValueOnce({
+        sum: null,
+        priceChange: {
+          percentage: [],
+          value: 0,
+        },
+      })
+      .mockReturnValueOnce({
+        sum: 1500,
+        priceChange: {
+          percentage: [0],
+          value: 0,
+        },
+      });
+
+    const accounts: Partial<Account>[] = [
+      {
+        addressAVM: 'addressAVM',
+        addressPVM: 'addressPVM',
+      },
+      {
+        addressPVM: 'addressPVM',
+      },
+      {
+        addressC: 'addressC',
+        addressBTC: 'addressBTC',
+      },
+      {
+        addressC: 'addressC',
+        addressAVM: 'addressAVM',
+        addressPVM: 'addressPVM',
+      },
+    ];
+
+    const balances = {} as any;
+    const chainIds = [];
+
+    const result = calculateTotalBalanceForAccounts(
+      balances,
+      accounts,
+      chainIds
+    );
+
+    expect(calculateTotalBalance).toHaveBeenCalledTimes(4);
+    expect(calculateTotalBalance).toHaveBeenNthCalledWith(
+      1,
+      accounts[0],
+      chainIds,
+      balances
+    );
+    expect(calculateTotalBalance).toHaveBeenNthCalledWith(
+      2,
+      accounts[1],
+      chainIds,
+      balances
+    );
+    expect(calculateTotalBalance).toHaveBeenNthCalledWith(
+      3,
+      accounts[2],
+      chainIds,
+      balances
+    );
+    expect(calculateTotalBalance).toHaveBeenNthCalledWith(
+      4,
+      accounts[3],
+      chainIds,
+      balances
+    );
+
+    expect(result).toEqual(1600);
+  });
+});

src/background/services/balances/handlers/getTotalBalanceForWallet/helpers/calculateTotalBalanceForAccounts.ts

@@ -0,0 +1,15 @@
+import { Account } from '@src/background/services/accounts/models';
+import { calculateTotalBalance } from '@src/utils/calculateTotalBalance';
+
+import { Balances } from '../../../models';
+
+export function calculateTotalBalanceForAccounts(
+  balances: Balances,
+  accounts: Partial<Account>[],
+  chainIds: number[]
+): number {
+  return accounts.reduce((sum: number, account: Partial<Account>) => {
+    const accountBalance = calculateTotalBalance(account, chainIds, balances);
+    return sum + (accountBalance.sum ?? 0);
+  }, 0);
+}