-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: p-chain dynamic fees #872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is really coming along! I left some more notes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Haven't checked everything yet, but wanted to stop and share a few questions regarding the useUnlockedUTXOs
. Please take a look at my comments below when you have a moment 👇
src/vms/pvm/etna-builder/spend-reducers/useUnlockedUTXOs.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
This is a first draft of changes needed for upcoming p-chain dynamic fees.
This PR introduces new utils and a new builder that is currently exposed alongside the existing builder. All new builder functions are currently exported under a
etna
specific directory.The new builder does not include any transactions types that are not supported post Etna upgrade.
Tests are added that align for the most part to the tests in
avalanchego
. However, the builder tests are a bit of a hybrid between existing builder tests and new changes needed for dynamic fee testing.Things this PR does not do (will come later)
Things not planned (currently)
avalanchego
's steps here, and the X-chain hasn't been worked on. Though the idea is that the changes will look very similar and there could be a lot of code reuse.Extra changes that do not effect current implementation.
readonly
. Mostly to keep my sanity that certain values were immutable. I wanted that extra piece of mind. All of the placesreadonly
is added it doesn't effect existing implementations and was already being treated as such.cspell
config but does not enforce it. Also added the CSpell extension recommendation to VSCode. Helps with spelling mistakes. ;)